[libvirt] [PATCH 00/14] Fix race on srv->nclients_unauth and some other changes

Marc Hartmayer mhartmay at linux.vnet.ibm.com
Tue Dec 12 11:36:22 UTC 2017


This patch series fixes some locking issues, memory leaks, some other
cosmetic changes, and it fixes a bug that led to a libvirtd which
doesn't accept new connections.

Marc Hartmayer (14):
  rpc: Remove duplicate declaration of virNetServerAddClient
  rpc: Fix memory leaks @virnetserverclient
  rpc: Use the enum value instead of a numerical value
  rpc: Add typedef for the anonymous enum used for authentication
    methods
  rpc: Be more precise in which cases the authentication is needed
  rpc: First test if authentication is required
  rpc: Correct locking and simplify the function
  rpc: Refactor the condition whether a client needs authentication
  rpc: Merge critical sections and preparations for upcoming patches
  rpc: Introduce virNetServerSetClientAuthenticated
  rpc: virnetserver: Fix race on srv->nclients_unauth
  tests: virnetdaemontest: Enable testing for 'auth_pending'
  rpc: Remove virNetServerClientNeedAuthLocked
  rpc: Replace virNetServerClientNeedAuth with
    virNetServerClientIsAuthenticated

 daemon/remote.c                                    |  13 +--
 src/libvirt_remote.syms                            |  14 +--
 src/rpc/virnetserver.c                             |  82 ++++++++++-----
 src/rpc/virnetserver.h                             |   6 +-
 src/rpc/virnetserverclient.c                       | 113 ++++++++++++++++-----
 src/rpc/virnetserverclient.h                       |  11 +-
 src/rpc/virnetserverprogram.c                      |   9 +-
 src/rpc/virnetserverservice.h                      |   4 +-
 .../input-data-client-auth-pending-failure.json    |  44 ++++++++
 .../input-data-client-auth-pending.json            |  70 +++++++++++++
 .../virnetdaemondata/output-data-admin-nomdns.json |   4 +
 .../output-data-admin-server-names.json            |   4 +
 .../virnetdaemondata/output-data-anon-clients.json |   2 +
 ...s.json => output-data-client-auth-pending.json} |   4 +-
 tests/virnetdaemondata/output-data-client-ids.json |   2 +
 .../output-data-client-timestamp.json              |   2 +
 .../output-data-initial-nomdns.json                |   2 +
 tests/virnetdaemondata/output-data-initial.json    |   2 +
 .../output-data-no-keepalive-required.json         |   4 +
 tests/virnetdaemontest.c                           |   2 +
 20 files changed, 310 insertions(+), 84 deletions(-)
 create mode 100644 tests/virnetdaemondata/input-data-client-auth-pending-failure.json
 create mode 100644 tests/virnetdaemondata/input-data-client-auth-pending.json
 copy tests/virnetdaemondata/{output-data-client-ids.json => output-data-client-auth-pending.json} (94%)

-- 
2.13.4




More information about the libvir-list mailing list