[libvirt] [PATCH v2] autogen.sh: tell user the correct make command

Daniel P. Berrange berrange at redhat.com
Tue Dec 12 15:57:23 UTC 2017

When autogen.sh finishes it helpfully prints

  "Now type 'make' to compile libvirt."

which is fine if on a host with GNU make, but on *BSD running
'make' will end in tears. We should tell users to run 'gmake'
on these platforms. If 'gmake' doesn't exist then we should
report an error too

  "GNU make is required to build libvirt"

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
 autogen.sh | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/autogen.sh b/autogen.sh
index d5d836aa71..ea94528de6 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -175,6 +175,18 @@ if test "$OBJ_DIR"; then
+# Make sure we can find GNU make and tell the user
+# the right command to run
+if make -v 2>&1 | grep -q "GNU Make"; then
+    MAKE=make
+    if which gmake >/dev/null 2>&1; then
+        MAKE=gmake
+    else
+        die "GNU make is required to build libvirt"
+    fi
 if test -z "$*" && test -z "$extra_args" && test -f config.status; then
     echo "Running config.status..."
     ./config.status --recheck || {
@@ -193,4 +205,4 @@ else
-echo "Now type 'make' to compile libvirt."
+echo "Now type '$MAKE' to compile libvirt."

More information about the libvir-list mailing list