[libvirt] [PATCH 0/6] Improvements to CPU frequency reporting
Bjoern Walk
bwalk at linux.vnet.ibm.com
Wed Dec 13 07:51:44 UTC 2017
Andrea Bolognani <abologna at redhat.com> [2017-12-12, 04:43PM +0100]:
> On Tue, 2017-12-12 at 12:52 +0100, Bjoern Walk wrote:
> > Andrea Bolognani <abologna at redhat.com> [2017-12-11, 05:40PM +0100]:
> > > A few steps towards eventually fixing
> > >
> > > https://bugzilla.redhat.com/show_bug.cgi?id=1206353
> > >
> > > The commit message for patch 6/6 contains most of the rationale,
> > > previous patches are cleanups. If not for the new test case added
> > > with patch 1/6, the overall diffstat would be negative.
> >
> > The timings... I have a similar patch set in my queue that I wanted to
> > send out today, but, well. I also have fixed frequency reporting on
> > S390, which I will at least rebase on top of this.
>
> I'm sorry! Some amount of duplicated work is kind of unavoidable
> in a loosely-organized community project such as libvirt.
No problem at all, I am glad that this code gets fixed by whoever, it
certainly deserved it.
>
> Hopefully rebasing on top of my series is not too much work,
> considering most of it is just refactoring and cleanups.
>
Should be no problem. I will wait for you to push this and then send out
the S390 improvements.
> > Before you push, I want to review this series and compare it with mine,
> > but I can't make it today I'm afraid. I will find the time to do it
> > tomorrow.
>
> I'd certainly appreciate that. The series doesn't have any ACKs
> yet, so there's no risk I'd push it before you can get to it :)
So, both our approached were fairly similar, with some bike-shedding
differences. For patch 2-5:
Reviewed-by: Bjoern Walk <bwalk at linux.vnet.ibm.com>
>
> --
> Andrea Bolognani / Red Hat / Virtualization
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
--
IBM Systems
Linux on z Systems & Virtualization Development
------------------------------------------------------------------------
IBM Deutschland
Schönaicher Str. 220
71032 Böblingen
Phone: +49 7031 16 1819
E-Mail: bwalk at de.ibm.com
------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 906 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171213/aa796312/attachment-0001.sig>
More information about the libvir-list
mailing list