[libvirt] [PATCH v5 3/3] libvirtd: fix crash on termination

Nikolay Shirokovskiy nshirokovskiy at virtuozzo.com
Thu Dec 14 12:21:11 UTC 2017



On 14.12.2017 15:09, Erik Skultety wrote:
> On Thu, Dec 14, 2017 at 02:58:30PM +0300, Nikolay Shirokovskiy wrote:
>> Hi, all.
>>
>> I looked over thread for this particular patch again and found resolution is we:
>>
>> 1. make a more sane cleanup order in libvirtd's main function (already done by [1]).
>> 2. rewrite linked series [2] by introducing event loop closing callback (ok)
>>
>> But there is no resolution on this patch itself if I am not mistaken and
>> it is not pushed too.
> 
> It's been a while and the thread became fairly large to track, correct me if
> I'm wrong but wouldn't the issue this patch is trying to solve disappear once
> we go with a reworked version of [2]?
> 

This way we can ask RPC threads serving requests of some driver to finish
but we can not be sure they are actually finish if we do not join them
before calling virStateCleanup.

Nikolay




More information about the libvir-list mailing list