[libvirt] [PATCH 05/14] rpc: Be more precise in which cases the authentication is needed

[John Ferlan]

On 12/12/2017 06:36 AM, Marc Hartmayer wrote:
> Additionally, use a whitelist model to decide whether authentication
> is needed or not.
> 
> Signed-off-by: Marc Hartmayer <mhartmay at linux.vnet.ibm.com>
> Reviewed-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
> Reviewed-by: Bjoern Walk <bwalk at linux.vnet.ibm.com>
> Reviewed-by: Stefan Zimmermann <stzi at linux.vnet.ibm.com>
> ---
>  src/rpc/virnetserverclient.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Considering later patches... Why not introduce the Locked version here
which just returns (client->auth == VIR_NET_SERVER_SERVICE_AUTH_NONE)?
and of course alter the commit message to say Introduce *Locked.

Hazards of not peeking forward by me.

John

> diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c
> index b454a3ff6992..0ee299e2d6ec 100644
> --- a/src/rpc/virnetserverclient.c
> +++ b/src/rpc/virnetserverclient.c
> @@ -1512,10 +1512,10 @@ int virNetServerClientSendMessage(virNetServerClientPtr client,
>  
>  bool virNetServerClientNeedAuth(virNetServerClientPtr client)
>  {
> -    bool need = false;
> +    bool need = true;
>      virObjectLock(client);
> -    if (client->auth)
> -        need = true;
> +    if (client->auth == VIR_NET_SERVER_SERVICE_AUTH_NONE)
> +        need = false;
>      virObjectUnlock(client);
>      return need;
>  }
>