[libvirt] [PATCH 12/14] tests: virnetdaemontest: Enable testing for 'auth_pending'

John Ferlan jferlan at redhat.com
Fri Dec 15 19:01:21 UTC 2017



On 12/12/2017 06:36 AM, Marc Hartmayer wrote:
> Enable testing for 'auth_pending' in the virnetdaemon test case.
> 
> Signed-off-by: Marc Hartmayer <mhartmay at linux.vnet.ibm.com>
> Reviewed-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
> ---
>  .../input-data-client-auth-pending-failure.json    | 44 ++++++++++++++
>  .../input-data-client-auth-pending.json            | 70 ++++++++++++++++++++++
>  .../output-data-client-auth-pending.json           | 70 ++++++++++++++++++++++
>  tests/virnetdaemontest.c                           |  2 +
>  4 files changed, 186 insertions(+)
>  create mode 100644 tests/virnetdaemondata/input-data-client-auth-pending-failure.json
>  create mode 100644 tests/virnetdaemondata/input-data-client-auth-pending.json
>  create mode 100644 tests/virnetdaemondata/output-data-client-auth-pending.json
> 

I assume the -failure test case is what I pointed out in the previous
patch, right?  That somehow the ExecRestart case was incorrect and that
the check should be there and not in the NewInternal helper.

In any case, for this patch... Thanks for the test it helps.

Reviewed-by: John Ferlan <jferlan at redhat.com>

John




More information about the libvir-list mailing list