[libvirt] [PATCH] admin: Use the connection to determine a client is connected readonly

John Ferlan jferlan at redhat.com
Fri Dec 15 19:53:21 UTC 2017



On 12/13/2017 10:47 AM, Erik Skultety wrote:
> Prior to this change, we relied solely on the inherited readonly
> attribute of a service's socket. This only worked for our UNIX sockets
> (and only to some degree), but doesn't work for TCP sockets which are RW
> by default, but such connections support RO as well. This patch forces
> an update on the client object once we have established a connection to
> reflect the nature of the connection itself rather than relying on the
> underlying socket's attributes.
> Clients connected to the admin server have always been connected as RW
> only.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1524399
> Signed-off-by: Erik Skultety <eskultet at redhat.com>
> ---
>  daemon/remote.c              |  5 +++++
>  src/libvirt_remote.syms      |  1 +
>  src/rpc/virnetserverclient.c | 11 +++++++++++
>  src/rpc/virnetserverclient.h |  1 +
>  4 files changed, 18 insertions(+)
> 

Reviewed-by: John Ferlan <jferlan at redhat.com>

John




More information about the libvir-list mailing list