[libvirt] [PATCH 07/12] apparmor, libvirt-qemu: add default pki path of lbvirt-spice

Christian Ehrhardt christian.ehrhardt at canonical.com
Wed Dec 20 11:41:30 UTC 2017


On Wed, Dec 20, 2017 at 10:45 AM, intrigeri <intrigeri+libvirt at boum.org> wrote:
> Jamie Strandboge:
>>> +  # for use by libvirt-spice (LP: #1690140)
>>> +  /etc/pki/libvirt-spice/ r,
>>> +  /etc/pki/libvirt-spice/** r,
>
>> +1 to apply
>
> +1 as well, although I'd prefer some minor refactoring to merge this
> with the 2 already existing libvirt-vnc PKI sections (that were added
> in two different places in the file 7 years apart, but apparently are
> about the exact same use case).
>
> Something like this should allow replacing these two existing sections
> and the third one you're proposing we add:
>
>   # for use by libvirt-vnc and libvirt-spice (LP: #901272, #1690140)
>   /etc/pki/CA/ r,
>   /etc/pki/CA/* r,
>   /etc/pki/libvirt{,-spice,-vnc}/ r,
>   /etc/pki/libvirt{,-spice,-vnc}/** r,
>
> What do you think?

Yes I like to take the opportunity to make this more readable in one
place while adding -spice.
Thanks for the suggestion!
Submitting as a v2 in reply ...




More information about the libvir-list mailing list