[libvirt] [PATCH 04/11] qemu_security: Kill code duplication

Peter Krempa pkrempa at redhat.com
Wed Feb 8 12:23:40 UTC 2017


On Wed, Feb 08, 2017 at 11:37:07 +0100, Michal Privoznik wrote:
> Nearly all of these functions look the same. Except for a
> different virSecurityManager API call. There is no need to copy
> paste the code when we can use macros to generate it.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_security.c | 179 ++++++++++++-----------------------------------
>  1 file changed, 44 insertions(+), 135 deletions(-)

NACK, please don't partialy define function with macros.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170208/601bf6d4/attachment-0001.sig>


More information about the libvir-list mailing list