[libvirt] [PATCH] qemu_cgroup: Only try to allow devices if devices CGroup's available

Ján Tomko jtomko at redhat.com
Thu Feb 23 10:15:14 UTC 2017


On Wed, Feb 22, 2017 at 04:38:59PM +0100, Michal Privoznik wrote:
>When a domain needs an access to some device (be it a disk, RNG,
>chardev, whatever), we have to allow it in the devices CGroup (if
>it is available), because by default we disallow all the devices.
>But some of the functions that are responsible for setting up
>devices CGroup are lacking check whether there is any CGroup
>available. Thus users might be unable to hotplug some devices:
>
>  virsh # attach-device fedora rng.xml
>  error: Failed to attach device from rng.xml
>  error: internal error: Controller 'devices' is not mounted
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/qemu/qemu_cgroup.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170223/0eb375bd/attachment-0001.sig>


More information about the libvir-list mailing list