[libvirt] [PATCH] qemu_process: spice: don't release used port

Martin Kletzander mkletzan at redhat.com
Fri Feb 24 09:08:12 UTC 2017


On Fri, Feb 24, 2017 at 09:58:31AM +0100, Pavel Hrdina wrote:
>The port is stored in graphics configuration and it will
>also get released in qemuProcessStop in case of error.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1397440
>
>Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>---
> src/qemu/qemu_process.c | 1 -
> 1 file changed, 1 deletion(-)
>

Nice how one removed line fixes two different issues :)

ACK

>diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
>index df1fa0371d..760507d957 100644
>--- a/src/qemu/qemu_process.c
>+++ b/src/qemu/qemu_process.c
>@@ -3693,7 +3693,6 @@ qemuProcessSPICEAllocatePorts(virQEMUDriverPtr driver,
>     ret = 0;
>
>  cleanup:
>-    virPortAllocatorRelease(driver->remotePorts, port);
>     virObjectUnref(cfg);
>     return ret;
> }
>--
>2.11.1
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170224/1dfcd500/attachment-0001.sig>


More information about the libvir-list mailing list