[libvirt] [PATCH] Remove additional newline from virsh-domain-monitor.c

Peter Krempa pkrempa at redhat.com
Wed Feb 8 12:21:13 UTC 2017


On Wed, Feb 08, 2017 at 14:20:49 +0530, Nitesh Konkar wrote:
> Currently "virsh domstats domainName" result ends
> with two blanklines. This shall remove the additional
> blank line.
> 
> Signed-off-by: Nitesh Konkar <nitkon12 at linux.vnet.ibm.com>
> ---
>  tools/virsh-domain-monitor.c | 1 -
>  1 file changed, 1 deletion(-)

NACK,

if you use virsh domstats to report stats for multiple VMs then the
output would not be separated any more:

Domain: 'hp'
  state.state=5
  state.reason=0
  balloon.maximum=1024000
  vcpu.current=2
  vcpu.maximum=10
  block.count=1
  block.0.name=hda
  block.0.path=/tmp/ble.img
Domain: 'rhel7.2-2'
  state.state=5
  state.reason=0
  balloon.maximum=1048576
  vcpu.current=2
  vcpu.maximum=8
  block.count=0
Domain: 'rhel7.2'
  state.state=5
  state.reason=0
  balloon.maximum=2097152
  vcpu.current=2
  vcpu.maximum=2
  block.count=1
  block.0.name=vda
  block.0.path=/var/lib/libvirt/images/rhel7.2.qcow2
  block.0.allocation=9665384448
  block.0.capacity=9663676416
  block.0.physical=9665380352

The only option would be if you skip it for the last entry.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170208/5af5ab3c/attachment-0001.sig>


More information about the libvir-list mailing list