[libvirt] [PATCH] conf: fix use-after-free when sending event message

[Wang King]

If there is a process with a client which registers event callbacks,
and it calls libvirt's API which uses the same virConnectPtr in that
callback function. When this process exit abnormally lead to client
disconnect, there is a possibility that the main thread is refer to
virServerClient just after the virServerClient been freed by job
thread of libvirtd.

Following is the backtrace:
#0 0x00007fda223d66d8 in virClassIsDerivedFrom 
(klass=0xdeadbeef,parent=0x7fda24c81b40)
#1 0x00007fda223d6a1e in virObjectIsClass 
(anyobj=anyobj at entry=0x7fd9e575b400,klass=)
#2 0x00007fda223d6a44 in virObjectLock (anyobj=anyobj at entry=0x7fd9e575b400)
#3 0x00007fda22507f71 in virNetServerClientSendMessage 
(client=client at entry=0x7fd9e575b400, msg=msg at entry=0x7fd9ec30de90)
#4 0x00007fda230d714d in remoteDispatchObjectEventSend 
(client=0x7fd9e575b400, program=0x7fda24c844e0, procnr=procnr at entry=348, 
proc=0x7fda2310e5e0 , data=data at entry=0x7ffc3857fdb0)
#5 0x00007fda230dd71b in remoteRelayDomainEventTunable (conn=, 
dom=0x7fda27cd7660, params=0x7fda27f3aae0, nparams=1, opaque=0x7fd9e6c99e00)
#6 0x00007fda224484cb in virDomainEventDispatchDefaultFunc 
(conn=0x7fda27cd0120, event=0x7fda2736ea00, cb=0x7fda230dd610 , 
cbopaque=0x7fd9e6c99e00)
#7 0x00007fda22446871 in virObjectEventStateDispatchCallbacks 
(callbacks=, callbacks=, event=0x7fda2736ea00, state=0x7fda24ca3960)
#8 virObjectEventStateQueueDispatch (callbacks=0x7fda24c65800, 
queue=0x7ffc3857fe90, state=0x7fda24ca3960)
#9 virObjectEventStateFlush (state=0x7fda24ca3960)
#10 virObjectEventTimer (timer=, opaque=0x7fda24ca3960)
#11 0x00007fda223ae8b9 in virEventPollDispatchTimeouts ()
#12 virEventPollRunOnce ()
#13 0x00007fda223ad1d2 in virEventRunDefaultImpl ()
#14 0x00007fda225046cd in virNetDaemonRun (dmn=dmn at entry=0x7fda24c775c0)
#15 0x00007fda230d6351 in main (argc=, argv=)

(gdb) p *(virNetServerClientPtr)0x7fd9e575b400
$2 = {parent = {parent = {u = {dummy_align1 = 140573849338048, 
dummy_align2 = 0x7fd9e65ac0c0, s = {magic = 3864707264, refs = 32729}}, 
klass = 0x7fda00000078}, lock = {lock = {__data = {__lock = 0,
__count = 0, __owner = 0, __nusers = 0, __kind = 0, __spins = 0, __list 
= {__prev = 0x0, __next = 0x0}}, __size = '\000' , __align = 0}}}, 
wantClose = false,
delayedClose = false, sock = 0x0, auth = 0, readonly = false, tlsCtxt = 
0x0, tls = 0x0, sasl = 0x0, sockTimer = 0, identity = 0x0, nrequests = 
0, nrequests_max = 0, rx = 0x0, tx = 0x0, filters = 0x0,
nextFilterID = 0, dispatchFunc = 0x0, dispatchOpaque = 0x0, privateData 
= 0x0, privateDataFreeFunc = 0x0, privateDataPreExecRestart = 0x0, 
privateDataCloseFunc = 0x0, keepalive = 0x0}
---
src/rpc/virnetserverclient.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c
index 81da82c..562516f 100644
--- a/src/rpc/virnetserverclient.c
+++ b/src/rpc/virnetserverclient.c
@@ -1021,6 +1021,12 @@ void 
virNetServerClientClose(virNetServerClientPtr client)
client->sock = NULL;
}

+ if (client->privateData &&
+ client->privateDataFreeFunc) {
+ client->privateDataFreeFunc(client->privateData);
+ client->privateData = NULL;
+ }
+
virObjectUnlock(client);
}

-- 
2.8.3

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170208/0ad217e1/attachment-0001.htm>