[libvirt] [PATCH] libxl: fix potential double free in libxlDriverGetDom0MaxmemConf
John Ferlan
jferlan at redhat.com
Wed Feb 15 23:43:40 UTC 2017
On 02/15/2017 12:49 PM, Jim Fehlig wrote:
> Commit 4ab0c959 fixed a memory leak in libxlDriverGetDom0MaxmemConf
> but introduced a potential double free of mem_tokens
>
> *** Error in `/usr/sbin/libvirtd': double free or corruption (out):
> 0x00007fffc808cfd0 ***
>
> Avoid double free by setting mem_tokens to NULL after calling
> virStringListFree.
>
> Signed-off-by: Jim Fehlig <jfehlig at suse.com>
> ---
> src/libxl/libxl_conf.c | 1 +
> 1 file changed, 1 insertion(+)
>
ACK
John (face-palm)
> diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
> index f5b788b50..4bab651b3 100644
> --- a/src/libxl/libxl_conf.c
> +++ b/src/libxl/libxl_conf.c
> @@ -1623,6 +1623,7 @@ libxlDriverGetDom0MaxmemConf(libxlDriverConfigPtr cfg,
> }
> }
> virStringListFree(mem_tokens);
> + mem_tokens = NULL;
> }
>
> physmem:
>
More information about the libvir-list
mailing list