[libvirt] [PATCH v2] node_device: Check return value for udev_new()

[Martin Kletzander]

On Fri, Feb 10, 2017 at 10:44:44AM +0100, Marc Hartmayer wrote:
>The comment was actually wrong as
>https://www.freedesktop.org/software/systemd/man/udev_new.html#
>mentions that on failure NULL is returned.
>
>Signed-off-by: Marc Hartmayer <mhartmay at linux.vnet.ibm.com>
>---
> src/node_device/node_device_udev.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>

ACK, sorry for the late review, I added one sentence to the commit
message and pushed it.  Thanks.

>diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
>index 4b81312..693194d 100644
>--- a/src/node_device/node_device_udev.c
>+++ b/src/node_device/node_device_udev.c
>@@ -1491,13 +1491,12 @@ static int nodeStateInitialize(bool privileged,
>     if (udevPCITranslateInit(privileged) < 0)
>         goto cleanup;
>
>-    /*
>-     * http://www.kernel.org/pub/linux/utils/kernel/hotplug/libudev/libudev-udev.html#udev-new
>-     *
>-     * indicates no return value other than success, so we don't check
>-     * its return value.
>-     */
>     udev = udev_new();
>+    if (!udev) {
>+        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
>+                       _("failed to create udev context"));
>+        goto cleanup;
>+    }
> #if HAVE_UDEV_LOGGING
>     /* cast to get rid of missing-format-attribute warning */
>     udev_set_log_fn(udev, (udevLogFunctionPtr) udevLogFunction);
>--
>2.5.5
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170220/b6713ba1/attachment-0001.sig>