[libvirt] [PATCH] qemuProcessInit: Jump onto correct label in case of error

Ján Tomko jtomko at redhat.com
Fri Feb 24 10:57:39 UTC 2017


On Thu, Feb 23, 2017 at 05:15:47PM +0100, Michal Privoznik wrote:
>After eca76884ea in case of error in qemuDomainSetPrivatePaths()
>in pretended start we jump to stop. I've changed this during
>review from 'cleanup' which turned out to be correct. Well, sort
>of. We can't call qemuProcessStop() as it decrements
>driver->nactive and we did not increment it. However, it calls
>virDomainObjRemoveTransientDef() which is basically the only
>function we need to call. So call that function and goto cleanup;
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/qemu/qemu_process.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170224/d3e56894/attachment-0001.sig>


More information about the libvir-list mailing list