[libvirt] [PATCH go v2] Add support for perf events
Nitesh Konkar
niteshkonkar.libvirt at gmail.com
Fri Feb 24 11:06:55 UTC 2017
On Fri, Feb 24, 2017 at 3:32 PM, Peter Krempa <pkrempa at redhat.com> wrote:
> On Fri, Feb 24, 2017 at 15:22:51 +0530, Nitesh Konkar wrote:
> > Signed-off-by: Nitesh Konkar <nitkon12 at linux.vnet.ibm.com>
> > ---
> > connect.go | 54 ++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++
> > domain.go | 54 ++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++
> > domain_compat.h | 36 ++++++++++++++++++++++++++++++++++++
> > 3 files changed, 144 insertions(+)
>
> The files are improperly indented. The go files use tabs for indentation
> while your code uses spaces. I've already pointed this out in v1.
>
I had read the review on v1 but could not understand exactly whats wrong
with the indentation as everything looked aligned on applying the patch.
Now its clear, shall send v3. Thanks.
>
> >
> > diff --git a/connect.go b/connect.go
> > index 3c53485..e24cf66 100644
> > --- a/connect.go
> > +++ b/connect.go
> > @@ -2264,6 +2264,24 @@ type DomainStatsPerf struct {
> > StalledCyclesBackend uint64
> > RefCpuCyclesSet bool
> > RefCpuCycles uint64
> > + CpuClockSet bool
> > + CpuClock uint64
> > + TaskClockSet bool
> > + TaskClock uint64
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170224/558ee660/attachment-0001.htm>
More information about the libvir-list
mailing list