[libvirt] [PATCH 1/9] s390: Cpu driver support for update and compare

[Jiri Denemark]

On Sun, Dec 18, 2016 at 14:22:21 -0500, Jason J. Herne wrote:
> Implement compare for s390. Required to test the guest against the host for
> guest cpu model runnability checking. We always return IDENTICAL to bypass
> Libvirt's checking. s390 will rely on Qemu to perform the runnability checking.
> 
> Implement update for s390. required to support use of cpu "host-model" mode.
> 
> Signed-off-by: Jason J. Herne <jjherne at linux.vnet.ibm.com>
> Acked-by: Jiri Denemark <jdenemar at redhat.com>
...
> diff --git a/src/cpu/cpu_s390.c b/src/cpu/cpu_s390.c
> index 04a6bea..bdc9ab5 100644
> --- a/src/cpu/cpu_s390.c
> +++ b/src/cpu/cpu_s390.c
> @@ -71,15 +71,84 @@ s390DataFree(virCPUDataPtr data)
...
> +static int
> +virCPUs390Update(virCPUDefPtr guest,
> +                 const virCPUDef *host)
> +{
...
> +     updated->mode = VIR_CPU_MODE_CUSTOM;
> +     if (virCPUDefCopyModel(updated, host, true) < 0)
> +         goto cleanup;
> +
> +     for (i = 0; i < guest->nfeatures; i++) {
> +         if (guest->features[i].policy == VIR_CPU_FEATURE_OPTIONAL) {
> +             virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
> +                            _("only cpu feature policies 'require' and "
> +                            "'disable' are supported for %s"),

s/"/  "/ still applies.

ACK

Jirka