[libvirt] [PATCH 9/9] qemu: command: Support new cpu feature argument syntax

Jiri Denemark jdenemar at redhat.com
Fri Jan 6 11:51:34 UTC 2017


On Sun, Dec 18, 2016 at 14:22:29 -0500, Jason J. Herne wrote:
> From: "Collin L. Walling" <walling at linux.vnet.ibm.com>
> 
> Qemu has abandoned the +/-feature syntax in favor of key=value. Some
> architectures (s390) do not support +/-feature. So we update libvirt to handle
> both formats.
> 
> If we detect a sufficiently new Qemu (indicated by support for qmp
> query-cpu-model-expansion) we use key=value else we fall back to +/-feature.
> 
> Signed-off-by: Collin L. Walling <walling at linux.vnet.ibm.com>
> Signed-off-by: Jason J. Herne <jjherne at linux.vnet.ibm.com>
> ---
>  src/qemu/qemu_command.c                            | 18 +++++++++++++++--
>  .../qemuxml2argv-cpu-s390-features.args            | 19 ++++++++++++++++++
>  .../qemuxml2argv-cpu-s390-features.xml             | 23 ++++++++++++++++++++++
>  tests/qemuxml2argvtest.c                           |  2 ++
>  4 files changed, 60 insertions(+), 2 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-s390-features.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-s390-features.xml

ACK

Jirka




More information about the libvir-list mailing list