[libvirt] [PATCH 00/12] vbox: remove support for vbox 3.x and older.

John Ferlan jferlan at redhat.com
Tue Jan 10 16:50:10 UTC 2017



On 12/29/2016 03:34 PM, Dawid Zamirski wrote:
> Hello,
> 
> This series removes support for legacy VirtualBox versions (3.x and
> older) that did not have upstream support for a while and won't even
> work on any relatively recent distro. The idea for doing this was
> first mentioned here [1] and this makes the driver code cleaner as
> the APIs for those old versions were quite different from v4.0+ and
> required abstractions to handle the differences.
> 
> Please note that the first patch in the series is sent to ML as a
> compressed attachment because it deletes VirtualBox SDK header files
> for those old verions which are large and the patch would not pass ML
> message size limit.
> 
> [1] https://www.redhat.com/archives/libvir-list/2016-November/msg01133.html
> 
> Regards,
> Dawid
> 
> Dawid Zamirski (12):
>   vbox: remove SDK header files for vbox 3 and older.
>   vbox: remove calls to *InstallUniformedAPI macros.
>   vbox: remove code for old API versions.
>   vbox: remove _vboxAttachDrivesOld
>   vbox: do not use IHardDisk anymore.
>   vbox: remove getMachineForSession flag.
>   vbox: remove domain events support.
>   vbox: remove code dealing with oldMediumInterface
>   vbox: IVRDxServer to IVRDEServer.
>   vbox: fix _displayTakeScreenShotPNGToArray
>   vbox: consolidate vbox IID structures.
>   docs: add news entry in improvements section.
> 
>  docs/news.html.in             |    8 +
>  src/Makefile.am               |    4 -
>  src/vbox/vbox_CAPI_v2_2.h     | 4869 -----------------------------------
>  src/vbox/vbox_CAPI_v3_0.h     | 5396 ---------------------------------------
>  src/vbox/vbox_CAPI_v3_1.h     | 5297 --------------------------------------
>  src/vbox/vbox_CAPI_v3_2.h     | 5625 -----------------------------------------
>  src/vbox/vbox_V2_2.c          |   37 -
>  src/vbox/vbox_V3_0.c          |   37 -
>  src/vbox/vbox_V3_1.c          |   37 -
>  src/vbox/vbox_V3_2.c          |   37 -
>  src/vbox/vbox_XPCOMCGlue.h    |    2 +-
>  src/vbox/vbox_common.c        |  402 +--
>  src/vbox/vbox_common.h        |   13 +-
>  src/vbox/vbox_network.c       |   12 +-
>  src/vbox/vbox_storage.c       |   76 +-
>  src/vbox/vbox_tmpl.c          | 3006 ++--------------------
>  src/vbox/vbox_uniformed_api.h |  171 +-
>  17 files changed, 438 insertions(+), 24591 deletions(-)
>  delete mode 100644 src/vbox/vbox_CAPI_v2_2.h
>  delete mode 100644 src/vbox/vbox_CAPI_v3_0.h
>  delete mode 100644 src/vbox/vbox_CAPI_v3_1.h
>  delete mode 100644 src/vbox/vbox_CAPI_v3_2.h
>  delete mode 100644 src/vbox/vbox_V2_2.c
>  delete mode 100644 src/vbox/vbox_V3_0.c
>  delete mode 100644 src/vbox/vbox_V3_1.c
>  delete mode 100644 src/vbox/vbox_V3_2.c
> 

Seems reasonable - it builds for me ;-).  I did take a cursory scan
through the changes - they all seem valid.

ACK series and can push everything before the release once/if the news
patches series on list can come to a resolution (otherwise, I'll use
news.html.in as this one does). Doubtful anyone has reservations about
removing all the cruft, but I will let the ACK sit for the rest of today
to see if anyone gripes ;-).


John

FWIW: I had to cleanup a few make syntax-check warnings in vbox_impl.c
due to not needing extra spaces on preprocessor indents (#define instead
of # define):

cppi: src/vbox/vbox_tmpl.c: line 159: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 160: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 260: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 261: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 262: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 263: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 264: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 266: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 817: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 819: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 852: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 855: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 863: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 865: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 867: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 893: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 895: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 1581: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 1587: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 1589: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 1591: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 1592: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 1596: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 1598: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 1600: not properly indented
cppi: src/vbox/vbox_tmpl.c: line 1601: not properly indented




More information about the libvir-list mailing list