[libvirt] [PATCH v3 0/3] Improve release notes process

John Ferlan jferlan at redhat.com
Tue Jan 10 18:28:16 UTC 2017



On 01/10/2017 11:55 AM, Andrea Bolognani wrote:
> On Tue, 2017-01-10 at 11:23 -0500, John Ferlan wrote:
>> I'm "mostly" fine with the changes - would like resolution sooner than
>> later since I have a couple of things to add to news, but I didn't want
>> to cause you extra merge cycles ;-)
> 
> Yeah, same here :)
> 
>> The *one* thing I'm really having a hard time with is not ending
>> sentences with a period for <description>'s.
> 
> What about <summary>?
> 
>> Especially when there's
>> two or more sentences within a <description> where the first one ends
>> with a period, but the second one doesn't
>>  
>> Not ending the previous paragraph without a period was really difficult
>> for my fingers.  I wouldn't hold up a ACK though for having or not
>> having a period.
> 
> Patch 1/3 translates the current entries directly to the new
> format, without any kind of editing.
> 
> As I've said before, I have zero problems having leading
> periods for all sentences in the release notes, especially
> if you feel so strongly about it :) We will have to change
> them all, though: an inconsistent style just won't do.
> 
> So, will you ACK this series if I promise to follow up with
> a patch that adds leading periods to all <description>s?

Sure, ACK with the caveat that I barely know how to spell xlst.

Let's see what we can break before the freeze ;-)

John

> 
> -- 
> Andrea Bolognani / Red Hat / Virtualization
> 




More information about the libvir-list mailing list