[libvirt] [PATCH v2] Add support for Veritas HyperScale (VxHS) block device protocol

[John Ferlan]

[...]

>> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args
>> new file mode 100644
>> index 0000000..f6e3e37
>> --- /dev/null
>> +++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args
>> @@ -0,0 +1,24 @@
>> +LC_ALL=C \
>> +PATH=/bin \
>> +HOME=/home/test \
>> +USER=test \
>> +LOGNAME=test \
>> +QEMU_AUDIO_DRV=none \
>> +/usr/libexec/qemu-kvm \
>> +-name QEMUGuest1 \
>> +-S \
>> +-M pc \
>> +-cpu qemu32 \
>> +-m 214 \
>> +-smp 1,sockets=1,cores=1,threads=1 \
>> +-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \
>> +-nographic \
>> +-nodefaults \
>> +-monitor unix:/tmp/lib/domain--1-QEMUGuest1/monitor.sock,server,nowait \
>> +-no-acpi \
>> +-boot c \
>> +-usb \
>> +-drive file=vxhs://192.168.0.1:9999/eb90327c-8302-4725-9e1b-4e85ed4dc251,\
>> +format=raw,if=none,id=drive-virtio-disk0,cache=none \
> 
> Please use the modern syntax for disk specification, not the
> legacy URI syntax  ie
> 
>   -drive  driver=vxhs,vdisk-id=eb90327c-8302-4725-4e85ed4dc251,\
>           server.host=example.com,server.port=12345,format=raw,
> 	  if=none,id=driver-virtio-disk0,cache=0
> 

FWIW: qemuBuildDriveStr doesn't support that yet for any driver -
although it probably should be updated... Timing wise whether that work
could get done before this work is ready - I'm not sure. While I agree
the code "should" use the new syntax - I do think we'd have to make
adjustments to all drive strings. That would probably mean knowing
whether the new syntax was "in place" before the current libvirt qemu
minimum version...

John