[libvirt] [PATCH] tests: fix compilation of shunloadtest

[Jim Fehlig]

On 01/17/2017 01:49 AM, Pavel Hrdina wrote:
> On Mon, Jan 16, 2017 at 11:06:17AM -0700, Jim Fehlig wrote:
>> While local builds succeed fine, a build worker building in a
>> chroot environment is encountering the following error with
>> libvirt 3.0.0 release candidates
>>
>> [  162s] shunloadtest.o: In function `main':
>> [  162s] /home/abuild/rpmbuild/BUILD/libvirt-3.0.0/tests/shunloadtest.c:110: undefined reference to `dlopen'
>> [  162s] /home/abuild/rpmbuild/BUILD/libvirt-3.0.0/tests/shunloadtest.c:114: undefined reference to `dlsym'
>> [  162s] /home/abuild/rpmbuild/BUILD/libvirt-3.0.0/tests/shunloadtest.c:133: undefined reference to `dlclose'
>> [  162s] /home/abuild/rpmbuild/BUILD/libvirt-3.0.0/tests/shunloadtest.c:111: undefined reference to `dlerror'
>> [  162s] /home/abuild/rpmbuild/BUILD/libvirt-3.0.0/tests/shunloadtest.c:115: undefined reference to `dlerror'
>> [  162s] /home/abuild/rpmbuild/BUILD/libvirt-3.0.0/tests/shunloadtest.c:116: undefined reference to `dlclose'
>>
>> Fix by appending LDADDS to shunloadtest_LDADD.
>>
>> Signed-off-by: Jim Fehlig <jfehlig at suse.com>
>> ---
>>  tests/Makefile.am | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/Makefile.am b/tests/Makefile.am
>> index c7d4748..112396f 100644
>> --- a/tests/Makefile.am
>> +++ b/tests/Makefile.am
>> @@ -1348,7 +1348,7 @@ libshunload_la_LDFLAGS = $(MOCKLIBS_LDFLAGS)
>>
>>  shunloadtest_SOURCES = \
>>  	shunloadtest.c
>> -shunloadtest_LDADD = $(LIB_PTHREAD)
>> +shunloadtest_LDADD = $(LIB_PTHREAD) $(LDADDS)
>
> I don't thing that this is a correct fix.  Some of the libs from LDADDS may
> include the dlopen libs but you cannot count on that.  It should be enough to
> add $(DLOPEN_LIBS).

Nod, thanks. V2 on the way...

Regards,
Jim