[libvirt] [PATCHv2 1/3] util: unlock closeCallbacks if get callbacks for connect fail
John Ferlan
jferlan at redhat.com
Wed Jan 18 23:34:42 UTC 2017
On 01/10/2017 01:23 AM, Wang King wrote:
> Avoid return with the closeCallbacks locked when get callbacks list for connect fail.
>
> Signed-off-by: Wang King <king.wang at huawei.com>
> ---
> src/util/virclosecallbacks.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
ACK,
John
> diff --git a/src/util/virclosecallbacks.c b/src/util/virclosecallbacks.c
> index 891a92b..1fa9596 100644
> --- a/src/util/virclosecallbacks.c
> +++ b/src/util/virclosecallbacks.c
> @@ -331,8 +331,10 @@ virCloseCallbacksRun(virCloseCallbacksPtr closeCallbacks,
>
> virObjectLock(closeCallbacks);
> list = virCloseCallbacksGetForConn(closeCallbacks, conn);
> - if (!list)
> + if (!list) {
> + virObjectLock(closeCallbacks);
> return;
> + }
>
> for (i = 0; i < list->nentries; i++) {
> char uuidstr[VIR_UUID_STRING_BUFLEN];
>
More information about the libvir-list
mailing list