[libvirt] [PATCH v1.5 2/6] storage: Split utility functions from storage_backend.(ch)

[John Ferlan]

On 01/18/2017 01:47 PM, Peter Krempa wrote:
> The file became a garbage dump for all kinds of utility functions over
> time. Move them to a separate file so that the files can become a clean
> interface for the storage backends.
> ---
>  po/POTFILES.in                         |    1 +
>  src/Makefile.am                        |    3 +-
>  src/storage/storage_backend.c          | 2954 +-------------------------------
>  src/storage/storage_backend.h          |  125 --
>  src/storage/storage_backend_disk.c     |    1 +
>  src/storage/storage_backend_fs.c       |    1 +
>  src/storage/storage_backend_gluster.c  |    1 +
>  src/storage/storage_backend_iscsi.c    |    1 +
>  src/storage/storage_backend_logical.c  |    1 +
>  src/storage/storage_backend_mpath.c    |    1 +
>  src/storage/storage_backend_rbd.c      |    1 +
>  src/storage/storage_backend_scsi.c     |    1 +
>  src/storage/storage_backend_sheepdog.c |    1 +
>  src/storage/storage_backend_zfs.c      |    1 +
>  src/storage/storage_driver.c           |    1 +
>  src/storage/storage_util.c             | 2919 +++++++++++++++++++++++++++++++
>  src/storage/storage_util.h             |  149 ++
>  tests/storagevolxml2argvtest.c         |    2 +-
>  18 files changed, 3117 insertions(+), 3047 deletions(-)
>  create mode 100644 src/storage/storage_util.c
>  create mode 100644 src/storage/storage_util.h
> 

Rather than adding #include "storage_util.h", why not add it to
src/storage/storage_backend.h since that's included by all that need it.
IDC either way.

While looking at what includes storage_backend.h I note that
*_mpath.{ch} both include storage_backend.h, but *_mpath.c doesn't
include *_mpath.h. It's the only one...

ACK -

John