[libvirt] [PATCH] bhyve: fix interface type handling for argv2xml

Roman Bogorodskiy bogorodskiy at gmail.com
Thu Jan 19 16:20:49 UTC 2017


  John Ferlan wrote:

> 
> 
> On 01/06/2017 12:12 PM, Roman Bogorodskiy wrote:
> > When generating a domain XML from native command (i.e. via
> > the connectDomainXMLFromNative call), we should use
> > interface type 'bridge' rather than 'ethernet' because we only
> > support bridges at this point.
> > 
> > As we don't have bridge name explicitly specified on the command line,
> > just use 'virbr0' as a default.
> > ---
> >  src/bhyve/bhyve_parse_command.c                       | 9 ++++++---
> >  tests/bhyveargv2xmldata/bhyveargv2xml-virtio-net.xml  | 6 ++++--
> >  tests/bhyveargv2xmldata/bhyveargv2xml-virtio-net4.xml | 3 ++-
> >  3 files changed, 12 insertions(+), 6 deletions(-)
> > 
> 
> Seems reasonable... ACK,

Pushed, thanks!

> John
> 

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170119/c1cc6604/attachment-0001.sig>


More information about the libvir-list mailing list