[libvirt] [PATCH 3/5] util: Introduce virFileMoveMount

Olaf Hering olaf at aepfle.de
Mon Jan 30 21:14:38 UTC 2017


On Wed, Jan 11, Michal Privoznik wrote:

> This is a simple wrapper over mount(). However, not every system
> out there is capable of moving a mount point. Therefore, instead
> of having to deal with this fact in all the places of our code we
> can have a simple wrapper and deal with this fact at just one
> place.

> +++ b/src/util/virfile.c

> +    const unsigned long mount_flags = MS_MOVE;


This fails to compile on systems without MS_MOVE, like openSUSE 11.4.
configure checks all sorts of things, perhaps it should detect the
presence of MS_MOVE as well and do the appropriate action.

[  306s] util/virfile.c:3618:39: error: 'MS_MOVE' undeclared (first use in this function)

Olaf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170130/93c20e02/attachment-0001.sig>


More information about the libvir-list mailing list