[libvirt] [PATCH v3 8/8] conf: aggregate multiple pcie-root-ports onto a single slot

[Laine Stump]

On 12/20/2016 12:50 PM, Andrea Bolognani wrote:
> On Mon, 2016-12-19 at 10:23 -0500, Laine Stump wrote:
>> Set the VIR_PCI_CONNECT_AGGREGATE_SLOT flag for pcie-root-ports so
>> that they will be assigned to all the functions on a slot.
>>   
>> Some qemu test case outputs had to be adjusted due to the
>> pcie-root-ports now being put on multiple functions.
> I noticed most of the pcie-root-ports get a new value for the
> port attribute after the change, while the chassis attribute
> remains always the same AFAICT.

That's because the chassis attribute is just set to the index of the 
controller, while port is set to slot<<3 + function (this was 
recommended by some PCI person, Alex I think). I believe chassis needs 
to be unique within the entire machine, while port needs to be unique 
only for the bus that the controller is connected to.

>
> I just thought I'd point it out, but I assume you were already
> aware of it and it's not an issue, in which case
>
> ACK
>
> -- 
> Andrea Bolognani / Red Hat / Virtualization
>