[libvirt] [PATCH] virutil: Provide non-linux impl for virGetFCHostNameByFabricWWN

Michal Privoznik mprivozn at redhat.com
Mon Jan 9 08:17:25 UTC 2017


Currently, there's only linux implementation for
virGetFCHostNameByFabricWWN(). Since the symbol is exported in
our private symbols we ought to have implementation for other
platforms too. This also triggers compilation error on FreeBSD:

../src/.libs/libvirt_driver_storage_impl.a(libvirt_driver_storage_impl_la-storage_backend_scsi.o): In function `createVport':
/usr/home/jenkins/libvirt-master/systems/libvirt-freebsd/build/src/../../src/storage/storage_backend_scsi.c:740: undefined reference to `virGetFCHostNameByFabricWWN'

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---

Pushed under trivial and build-breaker rules.

 src/util/virutil.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/util/virutil.c b/src/util/virutil.c
index da836b46d..aeaa7f98e 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
@@ -2480,6 +2480,14 @@ virGetFCHostNameByWWN(const char *sysfs_prefix ATTRIBUTE_UNUSED,
     return NULL;
 }
 
+char *
+virGetFCHostNameByFabricWWN(const char *sysfs_prefix ATTRIBUTE_UNUSED,
+                            const char *fabric_wwn ATTRIBUTE_UNUSED)
+{
+    virReportSystemError(ENOSYS, "%s", _("Not supported on this platform"));
+    return NULL;
+}
+
 char *
 virFindFCHostCapableVport(const char *sysfs_prefix ATTRIBUTE_UNUSED)
 {
-- 
2.11.0




More information about the libvir-list mailing list