[libvirt] [PATCH 00/12] vbox: remove support for vbox 3.x and older.

Dawid Zamirski dzamirski at datto.com
Tue Jan 10 20:09:41 UTC 2017


On Tue, 2017-01-10 at 11:50 -0500, John Ferlan wrote:
> 
> Seems reasonable - it builds for me ;-).  I did take a cursory scan
> through the changes - they all seem valid.
> 
> ACK series and can push everything before the release once/if the
> news
> patches series on list can come to a resolution (otherwise, I'll use
> news.html.in as this one does). Doubtful anyone has reservations
> about
> removing all the cruft, but I will let the ACK sit for the rest of
> today
> to see if anyone gripes ;-).
> 
> 
> John
> 
> FWIW: I had to cleanup a few make syntax-check warnings in
> vbox_impl.c
> due to not needing extra spaces on preprocessor indents (#define
> instead
> of # define):
> 

Whoops indeed - I've forgot to run make syntax-check before final
submission. Those were the result of removing wrapping #if..#endif
preprocessor directives that were used for old vbox versions which
reduced nesting level.

Regards,
Dawid




More information about the libvir-list mailing list