[libvirt] [PATCH] bhyve: fix interface type handling for argv2xml

John Ferlan jferlan at redhat.com
Wed Jan 18 14:20:45 UTC 2017



On 01/06/2017 12:12 PM, Roman Bogorodskiy wrote:
> When generating a domain XML from native command (i.e. via
> the connectDomainXMLFromNative call), we should use
> interface type 'bridge' rather than 'ethernet' because we only
> support bridges at this point.
> 
> As we don't have bridge name explicitly specified on the command line,
> just use 'virbr0' as a default.
> ---
>  src/bhyve/bhyve_parse_command.c                       | 9 ++++++---
>  tests/bhyveargv2xmldata/bhyveargv2xml-virtio-net.xml  | 6 ++++--
>  tests/bhyveargv2xmldata/bhyveargv2xml-virtio-net4.xml | 3 ++-
>  3 files changed, 12 insertions(+), 6 deletions(-)
> 

Seems reasonable... ACK,

John




More information about the libvir-list mailing list