[libvirt] [PATCH for 3.0.x] Disable use of namespaces by default
Guido Günther
agx at sigxcpu.org
Thu Jan 19 10:55:20 UTC 2017
On Wed, Jan 18, 2017 at 10:49:59AM +0000, Daniel P. Berrange wrote:
> When namespaces are enabled there is currently breakage when
> using disk hotplug and when using AppArmor
>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>
> I'm suggesting this for 3.0.x branch - we'll leave them enabled
> in master on the basis that we'll actually fix the real bugs
> there.
>
> src/qemu/qemu_conf.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
> index 6613d59..aa05b46 100644
> --- a/src/qemu/qemu_conf.c
> +++ b/src/qemu/qemu_conf.c
> @@ -317,13 +317,6 @@ virQEMUDriverConfigPtr virQEMUDriverConfigNew(bool privileged)
> if (!(cfg->namespaces = virBitmapNew(QEMU_DOMAIN_NS_LAST)))
> goto error;
>
> -#if defined(__linux__)
> - if (privileged &&
> - virProcessNamespaceAvailable(VIR_PROCESS_NAMESPACE_MNT) == 0 &&
> - virBitmapSetBit(cfg->namespaces, QEMU_DOMAIN_NS_MOUNT) < 0)
> - goto error;
> -#endif /* defined(__linux__) */
> -
> #ifdef DEFAULT_LOADER_NVRAM
> if (virFirmwareParseList(DEFAULT_LOADER_NVRAM,
> &cfg->firmwares,
> --
Having this on 3.0.x would be nice since I'm currently looking getting
3.0 into the next Debian stable.
Cheers,
-- Guido
More information about the libvir-list
mailing list