[libvirt] [PATCH 1/5] qemu: Only set group_name when actually requested

[Martin Kletzander]

On Wed, Jan 25, 2017 at 02:32:13PM +0100, Michal Privoznik wrote:
>On 01/25/2017 10:16 AM, Martin Kletzander wrote:
>> We were setting it based on whether it was supported and that lead to
>> setting it to NULL, which our JSON code caught.  However it ended up
>> producing the following results:
>>
>>  $ virsh blkdeviotune fedora vda --total-bytes-sec-max 2000
>>  error: Unable to change block I/O throttle
>>  error: internal error: argument key 'group' must not have null value
>>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>  src/qemu/qemu_driver.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>> index 516a851d3d55..f45972e3c823 100644
>> --- a/src/qemu/qemu_driver.c
>> +++ b/src/qemu/qemu_driver.c
>> @@ -17506,7 +17506,7 @@ qemuDomainSetBlockIoTune(virDomainPtr dom,
>>          qemuDomainObjEnterMonitor(driver, vm);
>>          ret = qemuMonitorSetBlockIoThrottle(priv->mon, device,
>>                                              &info, supportMaxOptions,
>> -                                            supportGroupNameOption,
>> +                                            set_fields & QEMU_BLOCK_IOTUNE_SET_GROUP_NAME,
>>                                              supportMaxLengthOptions);
>>          if (qemuDomainObjExitMonitor(driver, vm) < 0)
>>              ret = -1;
>>
>
>ACK, but the other options (Max and MaxLength) seem to suffer the same
>issue.
>

I believe that is handled by qemuDomainSetBlockIoTuneDefaults().  If
not, patches are welcome :D

>Michal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170125/a2b6b1b8/attachment-0001.sig>