[libvirt] [PATCH v2 1/5] storage: adds with_storage_vstorage buils option

[Olga Krishtal]

On 27/01/17 12:37, Peter Krempa wrote:
> On Fri, Jan 27, 2017 at 12:31:03 +0300, Olga Krishtal wrote:
>> On 27/01/17 12:09, Peter Krempa wrote:
>>> On Tue, Jan 17, 2017 at 17:10:55 +0300, Olga Krishtal wrote:
>>>> This patch only adds  --with-storage-vstorage build option.
>>>> In order to use vstorage as a backend for storage pool
>>>> vstorage tools should be installed.
>>>>
>>>> Signed-off-by: Olga Krishtal <okrishtal at virtuozzo.com>
>>>> ---
>>>>    configure.ac                |  4 +++
>>>>    m4/virt-storage-vstorage.m4 | 73 +++++++++++++++++++++++++++++++++++++++++++++
>>>>    2 files changed, 77 insertions(+)
>>>>    create mode 100644 m4/virt-storage-vstorage.m4
>>> [...]
>>>
>>>> @@ -0,0 +1,73 @@
>>>> +dnl The storage vstorage check
>>>> +dnl
>>>> +dnl Copyright (C) 2016  Parallels IP Holdings GmbH, Inc.
>>> This does not make sense. Is this company a GmbH or an Inc ?
>> Parallels IP Holdings GmbH - this is correct
> By the way, copying a file and than changing copyright information
> actually breaks the copyright.
>
> This is the case for this file, since there's a typo left from the 'fs'
> storage code that I'm going to send a patch for in a while. Also the
> leftover "Inc" from changing Red Hat to Parallels .. is a second clue.
Huh, I guess when we the new file is created  the copyright should be 
present, isn't it?
But there is no an example clean license text. =(
I need to be more attentive.
Do I need to send patch?


-- 
Best regards,
Olga