[libvirt] [PATCH 1/8] qemu: parse: drop redundant video config

Cole Robinson crobinso at redhat.com
Tue Jul 11 00:03:57 UTC 2017


On 06/28/2017 02:49 PM, Cole Robinson wrote:
> The ram/vram = 0 bits aren't needed, and PostParse will fill in the
> needed QXL default
> 
> Signed-off-by: Cole Robinson <crobinso at redhat.com>
> ---
>  src/qemu/qemu_command.c       |  4 ----
>  src/qemu/qemu_parse_command.c | 11 +----------
>  2 files changed, 1 insertion(+), 14 deletions(-)
> 
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index c53ab97b9..ebf9c63bc 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -7264,10 +7264,6 @@ qemuBuildObsoleteAccelArg(virCommandPtr cmd,
>          }
>          break;
>  
> -    case VIR_DOMAIN_VIRT_XEN:
> -        /* XXX better check for xenner */
> -        break;
> -
>      default:
>          virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
>                         _("the QEMU binary does not support %s"),
> diff --git a/src/qemu/qemu_parse_command.c b/src/qemu/qemu_parse_command.c
> index af9063c02..60c81f0ca 100644
> --- a/src/qemu/qemu_parse_command.c
> +++ b/src/qemu/qemu_parse_command.c
> @@ -2608,16 +2608,7 @@ qemuParseCommandLine(virCapsPtr caps,
>          virDomainVideoDefPtr vid;
>          if (VIR_ALLOC(vid) < 0)
>              goto error;
> -        if (def->virtType == VIR_DOMAIN_VIRT_XEN)
> -            vid->type = VIR_DOMAIN_VIDEO_TYPE_XEN;
> -        else
> -            vid->type = video;
> -        if (vid->type == VIR_DOMAIN_VIDEO_TYPE_QXL) {
> -            vid->vgamem = QEMU_QXL_VGAMEM_DEFAULT;
> -        } else {
> -            vid->ram = 0;
> -            vid->vgamem = 0;
> -        }
> +        vid->type = video;
>          vid->heads = 1;
>  
>          if (VIR_APPEND_ELEMENT(def->videos, def->nvideos, vid) < 0) {
> 

Now that I look closer at this patch, I realize I accidentally squashed
together two changes: the XEN removal was supposed to be its own patch. I'll
respin after review comes in

- Cole




More information about the libvir-list mailing list