[libvirt] [PATCH 9/9] tests: Validate that JSON deflattening fixed nested json pseudo-protocol strings

Peter Krempa pkrempa at redhat.com
Tue Jul 11 12:31:35 UTC 2017


On Mon, Jul 10, 2017 at 10:01:30 -0400, John Ferlan wrote:
> 
> 
> On 06/27/2017 08:46 AM, Peter Krempa wrote:
> > Sheepdog and possibly others use nested objects for network server and
> > thus could be specified in a way that libvirt would not parse.
> > 
> > Validates that https://bugzilla.redhat.com/show_bug.cgi?id=1464821
> > is fixed properly.
> > ---
> >  tests/virjsondata/deflatten-qemu-sheepdog-in.json  | 11 +++++++++++
> >  tests/virjsondata/deflatten-qemu-sheepdog-out.json | 13 +++++++++++++
> >  tests/virjsontest.c                                |  1 +
> >  tests/virstoragetest.c                             | 10 ++++++++++
> >  4 files changed, 35 insertions(+)
> >  create mode 100644 tests/virjsondata/deflatten-qemu-sheepdog-in.json
> >  create mode 100644 tests/virjsondata/deflatten-qemu-sheepdog-out.json
> > 
> 
> Reviewed-by: John Ferlan <jferlan at redhat.com>

Thanks for the review, I've implemented your suggestions and pushed the
patches.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170711/414b94bc/attachment-0001.sig>


More information about the libvir-list mailing list