[libvirt] [PATCH 7/8] secret: Properly handle @def after virSecretObjAdd in driver
Michal Privoznik
mprivozn at redhat.com
Tue Jul 11 15:52:01 UTC 2017
On 06/03/2017 03:27 PM, John Ferlan wrote:
> Since the virSecretObjListAdd technically consumes @def on success,
> the secretDefineXML should fetch the @def from the object afterwards
> and manage as an @objdef and set @def = NULL immediately.
Really? virSecretObjListAdd sets ->def pointer in the object, but it
doesn't touch the definition otherwise. So I think a caller is safe to
continue using the pointer.
Michal
More information about the libvir-list
mailing list