[libvirt] [PATCH] qemu: we prefer C89 comment styles over C99

Martin Kletzander mkletzan at redhat.com
Wed Jul 26 05:31:14 UTC 2017


On Tue, Jul 25, 2017 at 11:14:10PM +0200, Pavel Hrdina wrote:
>Introduced by commit 'a7bc2c8cfd6f'.
>
>Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>---
>
>Pushed under trivial rule.
>
> src/qemu/qemu_domain.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
>index dcdbfc9701..5c073027db 100644
>--- a/src/qemu/qemu_domain.c
>+++ b/src/qemu/qemu_domain.c
>@@ -7264,7 +7264,8 @@ qemuDomainPrepareChannel(virDomainChrDefPtr channel,
>                         "%s/%s", domainChannelTargetDir,
>                         channel->target.name) < 0)
>             return -1;
>-    } else {    // Generate a unique name
>+    } else {
>+        /* Generate a unique name */

Oh, thanks for catching this.  You could also remove the comment
altogether since the code is pretty self-explanatory, I guess.

Unless you already pushed it, s/we // in $SUBJ.

>         if (virAsprintf(&channel->source->data.nix.path,
>                         "%s/vioser-%02d-%02d-%02d.sock",
>                         domainChannelTargetDir,
>--
>2.13.3
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170726/2a442de0/attachment-0001.sig>


More information about the libvir-list mailing list