[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/8] qemuDomainCreateDeviceRecursive: Fail on unsupported file type



On 06/27/2017 11:55 PM, John Ferlan wrote:
> 
> 
> On 06/22/2017 12:18 PM, Michal Privoznik wrote:
>> Currently, we silently assume that file we are creating in the
>> namespace is either a link or a device (character or block one).
>> This is not always the case. Therefore instead of doing something
>> wrong, claim about unsupported file type.
>>
>> Signed-off-by: Michal Privoznik <mprivozn redhat com>
>> ---
>>  src/qemu/qemu_domain.c | 9 ++++++++-
>>  1 file changed, 8 insertions(+), 1 deletion(-)
>>
> 
> Your call - should the "%o" be a "0%o"  (see virStoragePoolDefFormatBuf
> and virFileMakePathHelper)?  I think that's the more "proper" formatting
> style used...
> 

Ah, good point. It really should be "0%o". I'll fix that.
Also, as I am looking around now what we use in other areas I've found
that we even have a syntax-check rule for using the latter. For some
reason it isn't caught here...

> 
> Reviewed-by: John Ferlan <jferlan redhat com>

Thanks.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]