[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/8] qemu: Move preserved mount points path generation into a separate function




On 07/10/2017 09:09 AM, Michal Privoznik wrote:
> On 06/27/2017 11:40 PM, John Ferlan wrote:
>>
>>
>> On 06/22/2017 12:18 PM, Michal Privoznik wrote:
>>> This function is going to be used on other places, so
>>> instead of copying code we can just call the function.
>>>
>>> Signed-off-by: Michal Privoznik <mprivozn redhat com>
>>> ---
>>>  src/qemu/qemu_domain.c | 59 ++++++++++++++++++++++++++++++--------------------
>>>  1 file changed, 36 insertions(+), 23 deletions(-)
>>>
>>> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
>>> index 212717c80..286d60761 100644
>>> --- a/src/qemu/qemu_domain.c
>>> +++ b/src/qemu/qemu_domain.c
>>> @@ -7572,6 +7572,41 @@ qemuDomainGetHostdevPath(virDomainDefPtr def,
>>>  }
>>>  
>>>  
>>
>> /* Returns allocated string on success which the caller must free and
>> NULL on failure */
> 
> Okay, I've extended this to:
> 
> /**
>  * qemuDomainGetPreservedMountPath:
>  * @cfg: driver configuration data
>  * @vm: domain object
>  * @mount: mount point path to convert
>  *
>  * For given @mount point return new path where the mount point
>  * should be moved temporarily whilst building the namespace.
>  *
>  * Returns: allocated string on success which the caller must free,
>  *          NULL on failure. */
> 

I hope the */ ended up on a new line...

>>
>> Reviewed-by: John Ferlan <jferlan redhat com>
> 
> Thanks.
> 
> Michal
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]