[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/2] Revert use of weak symbols

On 07/12/2017 12:14 PM, Daniel P. Berrange wrote:
> This series reverts the use of the __weak__ attribute which we did
> to fix the test suite with CLang. It cause unintended problems
> elsewhere which are not practical to fix. See the second patch
> for details.
> Daniel P. Berrange (2):
>   Revert "internal: don't use weak symbols for Win32 platform"
>   Revert "Prevent more compiler optimization of mockable functions"

So I thought about this too and I guess my question is - why are we not
dynamically linking with the mock libraries? What we do is use
LD_PRELOAD at runtime. However, if say virpcitest would link with
virpcimock at compile time (dynamically), we can throw away LD_PRELOAD
handling code.

On the other hand, this look trivial enough so I bet others have thought
of it. And since we don't use it there has to be catch that I'm missing. Or?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]