[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH v6 0/4] Make virNodeDeviceObj and virNodeDeviceObjList private

NB: Like v5, keeping same title for consistency

v5: https://www.redhat.com/archives/libvir-list/2017-July/msg00610.html

Changes since v5:
 * Replace patch 1 w/ the aha moment from review. The deletion API's
   don't need to use virNodeDeviceObjListGetParentHost. Instead they
   can just use virNodeDeviceObjListFindByName as the parent_wwnn/wwpn
   and parent_fabric_wwn are not stored in the vHBA. They're merely for
   the purpose of creation. The vHBA *does* store the def->parent by
   name and we can use that instead

 * Add patch 2 in order to remove the CREATE_DEVICE boolean from
   virNodeDeviceObjListGetParentHost as it won't be necessary since
   the only consumers are now CreateXML callers

 * Modify patch 3 calls to virHashSearch to add a NULL parameter since
   commit '38e516a52' added this (a real buzzkill for other changes too)

 * Modify patch 4 to include removing the locks in Nodedev calls for
   test_driver as well.

John Ferlan (4):
  nodedev: Alter node device deletion logic
  nodedev: Remove @create from virNodeDeviceObjListGetParentHost
  nodedev: Convert virNodeDeviceObjListPtr to use hash tables
  nodedev: Remove driver locks around object list mgmt code

 src/conf/virnodedeviceobj.c          | 580 ++++++++++++++++++++++++-----------
 src/conf/virnodedeviceobj.h          |   3 +-
 src/node_device/node_device_driver.c |  90 ++----
 src/node_device/node_device_hal.c    |  16 +-
 src/node_device/node_device_udev.c   |  13 +-
 src/test/test_driver.c               |  53 ++--
 6 files changed, 459 insertions(+), 296 deletions(-)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]