[libvirt] [PATCH 2/3] qemu: command: rework adding of default cpu model

[Ján Tomko]

On Fri, Jul 14, 2017 at 07:43:05PM -0400, Cole Robinson wrote:
>Certain XML features that aren't in the <cpu> block map to -cpu
>flags on the qemu cli. If one of these is specified but the user
>didn't explicitly pass an XML <cpu> model, we need to format a
>default model on the command line.
>
>The current code handles this by sprinkling this default cpu handling
>among all the different flag string formatting. Instead, switch it
>to do this just once.
>
>This alters some test output slightly: the previous code would
>write the default -cpu in some cases when no flags were actually
>added, so the output was redundant.
>
>Signed-off-by: Cole Robinson <crobinso at redhat.com>
>---
> src/qemu/qemu_command.c                            | 72 +++++++---------------
> .../qemuxml2argvdata/qemuxml2argv-hyperv-off.args  |  1 -
> .../qemuxml2argv-kvm-features-off.args             |  1 -
> 3 files changed, 22 insertions(+), 52 deletions(-)
>

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170721/880fc264/attachment-0001.sig>