[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 15/16] network: Modify naming for virNetworkObjList* fetching APIs



On Fri, May 19, 2017 at 09:03:23AM -0400, John Ferlan wrote:
> Use the structure names in the @data setup - makes it easier that going
> back to find the struct.
>
> Use the @maxnames instead of @nnames since that's what it is.

Please use camelCase -> @maxNames.

> 
> Modify the @filter to be @aclfilter and change the typedef from
> virNetworkObjListFilter to virNetworkObjListACLFilter.

NACK to this change, even though it's used only to filter by ACLs, it
can be used to filter by anything.

This patch does three things in one, so it should be three separate
patches.  Since the last change is not correct split the remaining
changes into two patches.

Pavel

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]