[libvirt] [PATCH] nodedev: Fix double unlock of the driver on udevEnumerateDevices failure

Martin Kletzander mkletzan at redhat.com
Wed Jul 26 11:24:04 UTC 2017


On Wed, Jul 26, 2017 at 10:45:11AM +0200, Erik Skultety wrote:
>Commit @4cb719b2dc moved the driver locks around since these have become
>unnecessary at spots where the code handles now self-lockable object
>list, but missed the possible double unlock if udevEnumerateDevices
>fails, because at that point the driver lock had been already dropped.
>
>Signed-off-by: Erik Skultety <eskultet at redhat.com>
>---
> src/node_device/node_device_udev.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>

The same issue still exists in the hal driver even after this patch.

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170726/a634044d/attachment-0001.sig>


More information about the libvir-list mailing list