[libvirt] [PATCH 12/24] qemu: block: Rename qemuBlockFillNodeData and move it to the top

Eric Blake eblake at redhat.com
Wed Jul 26 20:35:32 UTC 2017


On 07/26/2017 05:00 AM, Peter Krempa wrote:
> The same operation will become useful in other places so rename the
> function to be more generic and move it to the top so that it can be
> reused earlier in the file.
> ---
>  src/qemu/qemu_block.c | 38 +++++++++++++++++++-------------------
>  1 file changed, 19 insertions(+), 19 deletions(-)

> 
> diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
> index 22de70657..3afcbde94 100644
> --- a/src/qemu/qemu_block.c
> +++ b/src/qemu/qemu_block.c
> @@ -27,6 +27,24 @@
>  #define VIR_FROM_THIS VIR_FROM_QEMU
> 
> @@ -419,7 +419,7 @@ qemuBlockGetNodeData(virJSONValuePtr data)
>      if (!(ret = virHashCreate(50, virJSONValueHashFree)))
>          return NULL;
> 
> -    if (virJSONValueArrayForeachSteal(data, qemuBlockFillNodeData, ret) < 0)
> +    if (virJSONValueArrayForeachSteal(data, qemuBlockNamedNodesArrayToHash, ret) < 0)

Long line; worth wrapping?

Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170726/04ef81db/attachment-0001.sig>


More information about the libvir-list mailing list