[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 00/24] qemu: refactor node name detection

On 07/26/2017 05:00 AM, Peter Krempa wrote:
> Since query-blockstats provides full hierarchy of node names without any doubtful
> matching algorithm, use it to make the node name detector reliable.
> Unfortunately some of the changes are ugly when viewed as a diff since they
> delete and rewrite chunks of code.
> This series can be fetched at:
>  git fetch git://pipo.sk/pipo/libvirt.git node-name-detect-refactor-1

So far, I've just reviewed the patches, and found a few things to fix
although the overall impression was good.  I still hope to build and see
if I can manage to find problems in my own testing, but don't let that
be a bottleneck if you are trying to get this in before Thursday
morning's freeze (ie. we can do followup patches if I find something
later, if you can't wait for me to report results).

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]