[libvirt] [PATCH 3/3] virStream: Remove callbacks on Abort/Finish

Martin Kletzander mkletzan at redhat.com
Thu Jun 1 12:24:19 UTC 2017

On Thu, Jun 01, 2017 at 01:19:05PM +0100, Daniel P. Berrange wrote:
>On Thu, Jun 01, 2017 at 02:08:34PM +0200, Martin Kletzander wrote:
>> Users need to remove their callbacks before calling virStreamAbort()
>> or virStreamFinish() even though that's not documented anywhere.
>> Since it makes no sense to keep those callbacks, we can remove them
>> when the stream is being aborted or finished.  That way it is also
>> more intuitive for developers as that removes some confusing errors
>> being reported.
>This changes the semantics of a public API though, so even though
>the suggested behavious would be useful, we mustn't do this as it
>creates an API incompatability across versions.

I couldn't find any case that could be broken by this change.  Do you
have any in mind?

>|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
>|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
>|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
>libvir-list mailing list
>libvir-list at redhat.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170601/4d45cd46/attachment-0001.sig>

More information about the libvir-list mailing list