[libvirt] [PATCH] util: fixing wrong comparison inside virStoragePermsCopy().
Peter Krempa
pkrempa at redhat.com
Fri Jun 2 07:35:35 UTC 2017
On Thu, Jun 01, 2017 at 22:58:06 -0300, Julio Faracco wrote:
> VIR_STRDUP returns -1 if the string copy was not successful. So, the current
> comparison/logic is throwing an error when VIR_STRDUP() returns 1. Only when
> source is NULL, it is considering as a success which is not right.
>
> Signed-off-by: Julio Faracco <jcfaracco at gmail.com>
> ---
> src/util/virstoragefile.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
ACK, I'll rewrap the commit message and push this shortly.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170602/00f421d4/attachment-0001.sig>
More information about the libvir-list
mailing list