[libvirt] [PATCH v3 00/12] Make virNodeDeviceObj and virNodeDeviceObjList private

John Ferlan jferlan at redhat.com
Sat Jun 3 13:11:50 UTC 2017


v2: https://www.redhat.com/archives/libvir-list/2017-May/msg00999.html

Some patches from v2 were pushed (3, 4, 6, 7, 8, 9, 11, & 12), but a
few remained from that series and are the first 5 patches of this series.

What changed?
   -> Reworked the virNodeDeviceObjRemove patch (former patch 2, but new
     series patch 1). That affected the Test patch (former patch 1, but
     now patch 2). This patch removes the address of obj logic and moves
     the onus of the ObjFree to the caller (see patch for reason).
   -> Patch 3 is the former patch 5, with no essential change
   -> Patch 4 is the former patch 10, with no essential change
   -> Former patch 13 and 14, were altered to remove the offending
      address of pointer logic. The result is patch 5 which just
      essentially former patch 14 without the address of pointer logic.

   -> Patches 6-12 for this series are new, but follow along through the
      logic to make things private.

John Ferlan (12):
  nodedev: Alter virNodeDeviceObjRemove
  test: Adjust cleanup/error paths for nodedev test APIs
  nodedev: Use common naming for virnodedeviceobj
  nodedev: Use consistent names for driver variables
  nodedev: Introduce virNodeDeviceObjNew
  nodedev: Introduce virNodeDeviceObjListNew
  nodedev: Alter node device obj list function names
  nodedev: Dereference the obj/def in virNodeDeviceObjListFind* APIs
  nodedev: Introduce virNodeDeviceGetSCSIHostCaps
  nodedev: Introduce virNodeDeviceObjListFindSCSIHostByWWNs
  nodedev: Privatize _virNodeDeviceObj and _virNodeDeviceObjList
  nodedev: Convert virNodeDeviceObj to use virObjectLockable

 src/conf/node_device_conf.c               |  82 ++++++
 src/conf/node_device_conf.h               |  20 +-
 src/conf/virnodedeviceobj.c               | 420 ++++++++++++++++++------------
 src/conf/virnodedeviceobj.h               |  67 ++---
 src/libvirt_private.syms                  |  20 +-
 src/node_device/node_device_driver.c      | 159 +++++------
 src/node_device/node_device_hal.c         |  47 ++--
 src/node_device/node_device_linux_sysfs.c |  77 +-----
 src/node_device/node_device_udev.c        |  52 ++--
 src/test/test_driver.c                    | 136 +++++-----
 10 files changed, 570 insertions(+), 510 deletions(-)

-- 
2.9.4




More information about the libvir-list mailing list